Hi All, Great work Anuruddha, I have few comments on above change.
1. IMO we need to follow current standard of button positioning. So this force action button has to move on to right hand side. 2. I'm Not sure about the button name. Is it "Force Undeploy" or "Forcefully undeploy" @lahiru: AFAIK this appear if application undeloyment didn't get success. IMO undeployment is a main action to application. This is a secondary option that we are providing. So Do we need to push normal undeployment button to here? Thank you, Regards, *Dakshika Jayathilaka* PMC Member & Committer of Apache Stratos Senior Software Engineer WSO2, Inc. lean.enterprise.middleware 0771100911 On Wed, Jun 17, 2015 at 9:55 PM, Lahiru Sandaruwan <lahi...@wso2.com> wrote: > Great. Shall we bring the normal undeployment button to the same place? > > Thanks. > > On Wed, Jun 17, 2015 at 7:41 PM, Anuruddha Liyanarachchi < > anurudd...@wso2.com> wrote: > >> Hi Devs, >> >> I have added force undeploy button for UI. >> >> The flow is as follows: >> 1. User can un-deploy the application from UI. >> 2. Once the un-deployment process starts application will be in >> Undeploying state [1]. >> 3. In undeploying state user can view the application from topology view, >> which enables the "Force Undeploy" button. >> 4. User can decided to let application undeploy gracefully; Else user can >> undeploy applcaion forcefully by clicking the button on UI. [2] >> >> Please review and merge the PR [3] containing the changes: >> >> [1] >> https://drive.google.com/file/d/0B0v957zZwVWrbFFJN3o4U1JCRUE/view?usp=sharing >> [2] >> https://drive.google.com/file/d/0B0v957zZwVWrQml4R0gyMjExeWs/view?usp=sharing >> [3] https://github.com/apache/stratos/pull/370 >> >> Thanks, >> -- >> *Thanks and Regards,* >> Anuruddha Lanka Liyanarachchi >> Software Engineer - WSO2 >> Mobile : +94 (0) 712762611 >> Tel : +94 112 145 345 >> a <thili...@wso2.com>nurudd...@wso2.com >> > > > > -- > -- > Lahiru Sandaruwan > Committer and PMC member, Apache Stratos, > Senior Software Engineer, > WSO2 Inc., http://wso2.com > lean.enterprise.middleware > > phone: +94773325954 > email: lahi...@wso2.com blog: http://lahiruwrites.blogspot.com/ > linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146 > >
