Hi, @Anuruddha: Great work!!
@ Lahiru: The initial thought we had was that "Forceful Undeployment" is an advanced feature so that it should not come as a standard operation. If the Graceful Undeployment did not work due to a problem in the cartridge, the user could see this button on the Topology View as a mechanism to forcefully Undeploying the application. Anyway I can see a valid point in your argument. Thanks On Thu, Jun 18, 2015 at 11:07 AM, Lahiru Sandaruwan <lahi...@wso2.com> wrote: > Hi Dakshika, > > IMO graceful undeployment doesn't need to be the default. Graceful > undeployment is the case where, user want to complete serving of all the > requests that are serving at the moment of undeployment. > > If the user just want get rid of his deployment, he can do it forcefully. > So, we can have both options at the same level. > > Thanks. > > On Thu, Jun 18, 2015 at 10:13 AM, Dakshika Jayathilaka <daksh...@wso2.com> > wrote: > >> Hi Lahiru, >> >> I'm wondering why we want to push forceful action by default. Is there >> any real user story behind this action by default ? >> >> IMHO forceful actions are use if something goes wrong after default >> action. IMO first time user may get confused if we introduce force action >> by default. >> >> Regards, >> >> *Dakshika Jayathilaka* >> PMC Member & Committer of Apache Stratos >> Senior Software Engineer >> WSO2, Inc. >> lean.enterprise.middleware >> 0771100911 >> >> On Thu, Jun 18, 2015 at 8:19 AM, Lahiru Sandaruwan <lahi...@wso2.com> >> wrote: >> >>> Hi Dakshika, >>> >>> On Thu, Jun 18, 2015 at 7:37 AM, Dakshika Jayathilaka <daksh...@wso2.com >>> > wrote: >>> >>>> Hi All, >>>> >>>> Great work Anuruddha, I have few comments on above change. >>>> >>>> 1. IMO we need to follow current standard of button positioning. So >>>> this force action button has to move on to right hand side. >>>> >>>> 2. I'm Not sure about the button name. Is it "Force Undeploy" or >>>> "Forcefully undeploy" >>>> >>>> @lahiru: >>>> >>>> AFAIK this appear if application undeloyment didn't get success. >>>> >>> >>> User can directly use forceful undeployment. >>> >>>> IMO undeployment is a main action to application. This is a secondary >>>> option that we are providing. So Do we need to push normal undeployment >>>> button to here? >>>> >>>> >>> Actually i prefer to have all the actions, that are possible after >>> deployment, in this page. When the user views the application, he would >>> prefer to do these actions without going back. >>> >>> Thanks. >>> >>>> Thank you, >>>> >>>> Regards, >>>> >>>> *Dakshika Jayathilaka* >>>> PMC Member & Committer of Apache Stratos >>>> Senior Software Engineer >>>> WSO2, Inc. >>>> lean.enterprise.middleware >>>> 0771100911 >>>> >>>> On Wed, Jun 17, 2015 at 9:55 PM, Lahiru Sandaruwan <lahi...@wso2.com> >>>> wrote: >>>> >>>>> Great. Shall we bring the normal undeployment button to the same place? >>>>> >>>>> Thanks. >>>>> >>>>> On Wed, Jun 17, 2015 at 7:41 PM, Anuruddha Liyanarachchi < >>>>> anurudd...@wso2.com> wrote: >>>>> >>>>>> Hi Devs, >>>>>> >>>>>> I have added force undeploy button for UI. >>>>>> >>>>>> The flow is as follows: >>>>>> 1. User can un-deploy the application from UI. >>>>>> 2. Once the un-deployment process starts application will be in >>>>>> Undeploying state [1]. >>>>>> 3. In undeploying state user can view the application from topology >>>>>> view, which enables the "Force Undeploy" button. >>>>>> 4. User can decided to let application undeploy gracefully; Else user >>>>>> can undeploy applcaion forcefully by clicking the button on UI. [2] >>>>>> >>>>>> Please review and merge the PR [3] containing the changes: >>>>>> >>>>>> [1] >>>>>> https://drive.google.com/file/d/0B0v957zZwVWrbFFJN3o4U1JCRUE/view?usp=sharing >>>>>> [2] >>>>>> https://drive.google.com/file/d/0B0v957zZwVWrQml4R0gyMjExeWs/view?usp=sharing >>>>>> [3] https://github.com/apache/stratos/pull/370 >>>>>> >>>>>> Thanks, >>>>>> -- >>>>>> *Thanks and Regards,* >>>>>> Anuruddha Lanka Liyanarachchi >>>>>> Software Engineer - WSO2 >>>>>> Mobile : +94 (0) 712762611 >>>>>> Tel : +94 112 145 345 >>>>>> a <thili...@wso2.com>nurudd...@wso2.com >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> -- >>>>> Lahiru Sandaruwan >>>>> Committer and PMC member, Apache Stratos, >>>>> Senior Software Engineer, >>>>> WSO2 Inc., http://wso2.com >>>>> lean.enterprise.middleware >>>>> >>>>> phone: +94773325954 >>>>> email: lahi...@wso2.com blog: http://lahiruwrites.blogspot.com/ >>>>> linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146 >>>>> >>>>> >>>> >>> >>> >>> -- >>> -- >>> Lahiru Sandaruwan >>> Committer and PMC member, Apache Stratos, >>> Senior Software Engineer, >>> WSO2 Inc., http://wso2.com >>> lean.enterprise.middleware >>> >>> phone: +94773325954 >>> email: lahi...@wso2.com blog: http://lahiruwrites.blogspot.com/ >>> linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146 >>> >>> >> > > > -- > -- > Lahiru Sandaruwan > Committer and PMC member, Apache Stratos, > Senior Software Engineer, > WSO2 Inc., http://wso2.com > lean.enterprise.middleware > > phone: +94773325954 > email: lahi...@wso2.com blog: http://lahiruwrites.blogspot.com/ > linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146 > > -- Imesh Gunaratne Senior Technical Lead, WSO2 Committer & PMC Member, Apache Stratos
