[
https://issues.apache.org/jira/browse/STREAMS-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324783#comment-14324783
]
ASF GitHub Bot commented on STREAMS-288:
----------------------------------------
Github user smashew commented on the pull request:
https://github.com/apache/incubator-streams/pull/187#issuecomment-74741241
:+1: no idea how this was merged. scanning the class path with each datum
would be bad, let alone each datum for each iteration in the stream. wowza!
I propose that we figure out a way to time tests to see if there is a
significant performance degradation in on the integration tests to avoid this
issue in the future.
> StreamsJacksonModule should not scan for DateTimeFormats by default
> -------------------------------------------------------------------
>
> Key: STREAMS-288
> URL: https://issues.apache.org/jira/browse/STREAMS-288
> Project: Streams
> Issue Type: Bug
> Reporter: Robert Douglas
>
> The StreamsJacksonModule's constructor is called all over the codebase and by
> default, it uses Reflections to scan the classpath for valid DateTimeFormats.
> This is problematic because it will happen multiple times during a Stream's
> runtime, considerably slowing down the execution.
> Instead, we should default to NOT scanning the classpath, but provide a
> constructor where we can pass in a flag dictating whether or not we want to
> scan.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
