[
https://issues.apache.org/jira/browse/STREAMS-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324827#comment-14324827
]
ASF GitHub Bot commented on STREAMS-288:
----------------------------------------
Github user robdouglas commented on the pull request:
https://github.com/apache/incubator-streams/pull/187#issuecomment-74746871
@steveblackmon if the entire code base used getInstance() where appropriate
then this wouldn't be as much of an issue. However, there are 34 instances in
the code base where we're calling `new StreamsJacksonMapper()` which results in
these gratuitous Reflections calls.
> StreamsJacksonModule should not scan for DateTimeFormats by default
> -------------------------------------------------------------------
>
> Key: STREAMS-288
> URL: https://issues.apache.org/jira/browse/STREAMS-288
> Project: Streams
> Issue Type: Bug
> Reporter: Robert Douglas
>
> The StreamsJacksonModule's constructor is called all over the codebase and by
> default, it uses Reflections to scan the classpath for valid DateTimeFormats.
> This is problematic because it will happen multiple times during a Stream's
> runtime, considerably slowing down the execution.
> Instead, we should default to NOT scanning the classpath, but provide a
> constructor where we can pass in a flag dictating whether or not we want to
> scan.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
