[
https://issues.apache.org/jira/browse/STREAMS-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324844#comment-14324844
]
ASF GitHub Bot commented on STREAMS-288:
----------------------------------------
Github user steveblackmon commented on the pull request:
https://github.com/apache/incubator-streams/pull/187#issuecomment-74748109
fair point. i'll happily merge a PR that protects the constructor and
refactors project source and tests to use the singleton.
> StreamsJacksonModule should not scan for DateTimeFormats by default
> -------------------------------------------------------------------
>
> Key: STREAMS-288
> URL: https://issues.apache.org/jira/browse/STREAMS-288
> Project: Streams
> Issue Type: Bug
> Reporter: Robert Douglas
>
> The StreamsJacksonModule's constructor is called all over the codebase and by
> default, it uses Reflections to scan the classpath for valid DateTimeFormats.
> This is problematic because it will happen multiple times during a Stream's
> runtime, considerably slowing down the execution.
> Instead, we should default to NOT scanning the classpath, but provide a
> constructor where we can pass in a flag dictating whether or not we want to
> scan.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
