[
https://issues.apache.org/jira/browse/STREAMS-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324786#comment-14324786
]
ASF GitHub Bot commented on STREAMS-288:
----------------------------------------
Github user smashew commented on the pull request:
https://github.com/apache/incubator-streams/pull/187#issuecomment-74741753
I mean, technically, this allevates the issue.
A better approach would be
private final static Class<? extends StreamsDateFormat> dtClazzes;
static {
// Load dtClazzes
// Scanner slow stuff here... Put a LOGGER.info("") message to apologize to
the user how long this will take and that you are sorry for the inconvenience.
}
> StreamsJacksonModule should not scan for DateTimeFormats by default
> -------------------------------------------------------------------
>
> Key: STREAMS-288
> URL: https://issues.apache.org/jira/browse/STREAMS-288
> Project: Streams
> Issue Type: Bug
> Reporter: Robert Douglas
>
> The StreamsJacksonModule's constructor is called all over the codebase and by
> default, it uses Reflections to scan the classpath for valid DateTimeFormats.
> This is problematic because it will happen multiple times during a Stream's
> runtime, considerably slowing down the execution.
> Instead, we should default to NOT scanning the classpath, but provide a
> constructor where we can pass in a flag dictating whether or not we want to
> scan.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
