Hi Ioan,
sorry for late reply: it's a rather busy period over here...
See my comments in-line below.
Regards.
On 19/07/2014 10:25, Ioan Eugen Stan wrote:
Hello Francesco, Andrea, devs,
>
> Thanks for the support and enthusiasm. I am an apache committer for
> James project (my id is ieugen) so, naturally, I like to contribute to
> other projects as well.
That's great :-)
As I've said on the user list, I would like to donate the code to
> Syncope project. The package is usable but there are still things to
> improve. Some of them can be done only with code changes.
>
> Francesco, let me know what we should do to submit the code upstream. I
> have created a JIRA to track this [1].
Since you are already an Apache committer, there is no need for a CLA
from your side.
Providing a patch for SYNCOPE-535 seems then the most suitable option.
You should then re-factor your project at GitHub as a submodule of the
root Syncope pom.xml
https://svn.apache.org/repos/asf/syncope/branches/1_1_X/
and then generate a patch that you can attach to SYNCOPE-535.
The most notable changes that I would like to see is more 'production'
> friendliness. The ability to replace the current application with a new
> one easily and the ability to change configuration parameters without
> rebuilding the application.
Interesting: until now we have always pushed the idea that any new
Syncope deployment should start from the archetype - and then the need
to reference configuration files from outside the resulting webapps was
very low.
However, I recognize this approach is hardly suitable for the needs of a
deb (or RPM, why not?) package.
This boils down to separating the application in: configuration,
> binaries (jars) and application data (logs, data, database). You should
> be able to supply the path to the main configuration file via system
> property and all other configuration files should be referenced from
> this one.
As you might have seen from this wiki page:
https://cwiki.apache.org/confluence/display/SYNCOPE/Run+Syncope+in+real+environments#RunSyncopeinrealenvironments-Buildanddeploy
the paths for the bundles and logs directories are already to be
provided for production environments.
There are, however, other configuration files (.properties) that should
be possible to put outside of syncope.war and syncope-console.war (and
then placed, for example, into /etc/default/apache-syncope on a Debian
system).
This might require some additional Spring configuration (as did in the
past for console's configuration.properties - that absolutely needs to
be renamed BTW) and possibly some minor Java adjustments, but it is
definitely feasible.
Once we got the patch from you we can also work on such fine-grain aspects.
You should also have the ability to add files to the class-path without
> re-building the application if it has modules (like the connectors). So
> loading jars from a location should be configurable.
This is already working like this: connectors can reside in some
location(s) of the file system or even remotely
https://cwiki.apache.org/confluence/display/SYNCOPE/Configure+ConnId+locations
These are some thoughts I have, you probably know if all of them make
> sense.
>
> I would like to contribute some of these changes myself albeit I have
> the time (or I am payed to do so and then I make time ;) ).
Well, I also wish to get paid for my work on Syncope, do you know
someone interested? ;-)
Jokes apart, it's always nice when you can pay your bills with Open
Source activities, but unfortunately it does not occur frequently enough...
Looking forward to take a look at your patch.
Regards.
[1] https://issues.apache.org/jira/browse/SYNCOPE-535
>
> On 19.07.2014 08:49, andrea patricelli wrote:
>> Sounds good. Very interesting and nice work!
>> +1
>>
>> Best regards,
>> Andrea
>>
>> Il 19/lug/2014 07:14 =?ISO-8859-1?Q?Francesco_Chicchiricc=F2?=
<ilgro...@apache.org> ha scritto:
>>>
>>> [Sending again to allow Ioan joining the discussion]
>>>
>>> Hi all,
>>> as you might have read [1] there is a project on GitHub [2] for
>>> providing Debian packages for Apache Syncope.
>>>
>>> I have taken a quick look at it seems very interesting.
>>>
>>> Since the author says
>>>> I would like to see the work upstream if possible.
>>>
>>> I suppose - I've asked for confirmation though - that he is willing to
>>> donate.
>>>
>>> In this case, besides some changes that might be required for
complying
>>> with Debian packaging policies (about file locations, for example), I
>>> wonder if providing .deb downloadable artifacts might require some
>>> additional work - OpenOffice is doing this, so I do assume it is
feasible.
>>>
>>> WDYT?
>>>
>>> [1] http://markmail.org/message/grzgm22b64p4hmo7
>>> [2] https://github.com/ieugen/apache-syncope-debian
--
Francesco Chicchiriccò
Tirasa - Open Source Excellence
http://www.tirasa.net/
Involved at The Apache Software Foundation:
member, Syncope PMC chair, Cocoon PMC, Olingo PMC
http://people.apache.org/~ilgrosso/
