[ 
https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490434#comment-14490434
 ] 

ASF GitHub Bot commented on THRIFT-3090:
----------------------------------------

GitHub user marco-m opened a pull request:

    https://github.com/apache/thrift/pull/434

    Fix THRIFT-3090 (cmake build is broken)

    Problem found and fixed on Mac OS X 10.10.3, but at least the link problems 
must happen on every OS.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/marco-m/thrift THRIFT-3090

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/434.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #434
    
----
commit 73821578c4f54c36331d522b4cd685af7d539e18
Author: Marco Molteni <marco.molt...@laposte.net>
Date:   2015-04-10T21:51:19Z

    Fix THRIFT-3090 (cmake build is broken)

----


> cmake build is broken
> ---------------------
>
>                 Key: THRIFT-3090
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3090
>             Project: Thrift
>          Issue Type: Bug
>            Reporter: Marco Molteni
>
> A current version of apache/thrift on github as of 2015-04-10 doesn't build 
> with cmake due to multiple errors:
> - some C++ targets fail to link with missing symbols, because they do not 
> link against the `thrift` library
> - the c_glib test targets fail to build because the reference to `shared_ptr` 
> is considered ambiguous by the compiler (it resolves to both boost and stdlib 
> shared_ptr)
> This makes me wonder about the overall status of cmake support.
> In any case, I am opening this issue in order to create a github pull request 
> with a fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to