[
https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491481#comment-14491481
]
ASF GitHub Bot commented on THRIFT-3090:
----------------------------------------
Github user marco-m commented on a diff in the pull request:
https://github.com/apache/thrift/pull/434#discussion_r28203837
--- Diff: build/cmake/DefinePlatformSpecifc.cmake ---
@@ -58,8 +58,9 @@ if(MSVC)
endif(WITH_MT)
endif(MSVC)
-# GCC Specific
-if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX)
+# GCC or Clang specific
+if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX OR
CMAKE_CXX_COMPILER_ID MATCHES "Clang")
--- End diff --
Unfortunately CMAKE_COMPILER_IS_CLANG doesn't exist (or at least didn't
exist last time I researched the topic).
> cmake build is broken
> ---------------------
>
> Key: THRIFT-3090
> URL: https://issues.apache.org/jira/browse/THRIFT-3090
> Project: Thrift
> Issue Type: Bug
> Environment: Mac OS X 10.10.3
> C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0
> (clang-600.0.57) (based on LLVM 3.5svn)
> boost 1.57
> cmake 3.2.1
> Reporter: Marco Molteni
>
> A current version of apache/thrift on github as of 2015-04-10 doesn't build
> with cmake due to multiple errors:
> - some C++ targets fail to link with missing symbols, because they do not
> link against the `thrift` library
> - the c_glib test targets fail to build because the reference to `shared_ptr`
> is considered ambiguous by the compiler (it resolves to both boost and stdlib
> shared_ptr)
> See pull request https://github.com/apache/thrift/pull/434
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
