[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491479#comment-14491479 ]
ASF GitHub Bot commented on THRIFT-3090: ---------------------------------------- Github user marco-m commented on a diff in the pull request: https://github.com/apache/thrift/pull/434#discussion_r28203820 --- Diff: lib/cpp/CMakeLists.txt --- @@ -26,7 +26,7 @@ if(WITH_BOOSTTHREADS) else() find_package(Boost 1.53.0 REQUIRED) endif() -include_directories(SYSTEM "${Boost_INCLUDE_DIRS}") --- End diff -- I don't need to remove SYSTEM to fix the cmake build on Mac OS X. On the other hand, I don't see why SYSTEM is needed :-) In any case, this change can be reverted. > cmake build is broken > --------------------- > > Key: THRIFT-3090 > URL: https://issues.apache.org/jira/browse/THRIFT-3090 > Project: Thrift > Issue Type: Bug > Environment: Mac OS X 10.10.3 > C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0 > (clang-600.0.57) (based on LLVM 3.5svn) > boost 1.57 > cmake 3.2.1 > Reporter: Marco Molteni > > A current version of apache/thrift on github as of 2015-04-10 doesn't build > with cmake due to multiple errors: > - some C++ targets fail to link with missing symbols, because they do not > link against the `thrift` library > - the c_glib test targets fail to build because the reference to `shared_ptr` > is considered ambiguous by the compiler (it resolves to both boost and stdlib > shared_ptr) > See pull request https://github.com/apache/thrift/pull/434 -- This message was sent by Atlassian JIRA (v6.3.4#6332)