Github user nsuke commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/628#discussion_r45576807
  
    --- Diff: lib/cpp/test/CMakeLists.txt ---
    @@ -25,6 +25,10 @@ include_directories(SYSTEM "${Boost_INCLUDE_DIRS}")
     #Make sure gen-cpp files can be included
     include_directories("${CMAKE_CURRENT_BINARY_DIR}")
     
    +if (MINGW)
    +  add_definitions(-DBOOST_TEST_DYN_LINK)
    +endif()
    +
    --- End diff --
    
    I don't think `BOOST_TEST_DYN_LINK` is related to mingw.
    You may want to pass it to cmake by `-DCMAKE_CXX_FLAGS="-D..."` option 
instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to