Github user becrux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45579221
--- Diff: lib/cpp/test/CMakeLists.txt ---
@@ -25,6 +25,10 @@ include_directories(SYSTEM "${Boost_INCLUDE_DIRS}")
#Make sure gen-cpp files can be included
include_directories("${CMAKE_CURRENT_BINARY_DIR}")
+if (MINGW)
+ add_definitions(-DBOOST_TEST_DYN_LINK)
+endif()
+
--- End diff --
You're right, it's not related to mingw strictly, it's related to the way
you build Boost under MinGW. Your idea is fine, I was finding a way to detect
if Boost requires dynamic linking automatically, but I didn't find any method.
We could ignore this diff, if that's not possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
