Github user nsuke commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/628#discussion_r45577051
  
    --- Diff: lib/cpp/test/OpenSSLManualInitTest.cpp ---
    @@ -67,6 +67,22 @@ void test_openssl_availability() {
       openssl_cleanup();
     }
     
    --- End diff --
    
    Just an idea but BOOST_TEST_MAIN or (even better) BOOST_TEST_MODULE work 
instead of these `main`s ?
    
    I'm fine with the current approach, though.
    We have a bug report for boost test dynamic linking and this certainly 
solves it and it's great.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to