Github user becrux commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/628#discussion_r45579299
  
    --- Diff: lib/cpp/test/SecurityTest.cpp ---
    @@ -108,8 +108,13 @@ struct SecurityFixture : public TestPortFixture
     
                 pServerSocketFactory.reset(new 
TSSLSocketFactory(static_cast<apache::thrift::transport::SSLProtocol>(protocol)));
                 
pServerSocketFactory->ciphers("ALL:!ADH:!LOW:!EXP:!MD5:@STRENGTH");
    +          #ifdef BOOST_WINDOWS_API
    +            
pServerSocketFactory->loadCertificate(certFile("server.crt").string().c_str());
    +            
pServerSocketFactory->loadPrivateKey(certFile("server.key").string().c_str());
    +          #else
                 
pServerSocketFactory->loadCertificate(certFile("server.crt").native().c_str());
                 
pServerSocketFactory->loadPrivateKey(certFile("server.key").native().c_str());
    +          #endif
                 pServerSocketFactory->server(true);
    --- End diff --
    
    But if fails with MinGW, due to a conflict between string / wstring, when 
using "native" or "string" method.
    
    Here too, if you have a more portable method, please modify it at will.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to