[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530294#comment-15530294
]
ASF GitHub Bot commented on THRIFT-3873:
----------------------------------------
Github user nsuke commented on the issue:
https://github.com/apache/thrift/pull/1044
@jeking3 hi, sorry for the delay, what is your thought on "#define
__STDC_LIMIT_MACROS + ..._MAX" v.s. numeric_limists<...>::max() ?
If it were my own code, I would always use numeric_limists but I had once
very strange compilation error on VC++14 with this too.
Do you think define + _MAX is better or as good for our code base ?
> Fix various compiler warnings when using VS2010
> -----------------------------------------------
>
> Key: THRIFT-3873
> URL: https://issues.apache.org/jira/browse/THRIFT-3873
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0
> Environment: VS2010, Windows
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Trivial
>
> While verifying a defect I had to build the windows thrift C++ library and
> found a number of compiler warnings that needed to be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
