[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188375#comment-16188375
]
ASF GitHub Bot commented on THRIFT-4285:
----------------------------------------
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1382
> I don't think we can unilaterally require go 1.9 at this point without
causing some pain, but I'm not sure.
This change doesn't effect the user, it's only needed for the tests. Though
if you still think we shouldn't do it, I can change the tests to use older
APIs. I didn't want to touch it since I didn't write the original patch.
> It looks like this may not be backwards compatible with existing code -
is there any way to put in an adapter that would allow existing code to
continue working?
I don't think so. Several interfaces had to change since what used to be
returned from generated methods is now returned from the library.
Good news is the changes are limited to client, server and protocol
interfaces (they don't affect the signature for RPCs) so updating to 0.11
should be a few lines of change (initializing the server/client) for most
people.
Just to make sure, I'll update a real application to this patch and post my
experiences here.
> Pull generated send/recv into library to allow behaviour to be customised
> -------------------------------------------------------------------------
>
> Key: THRIFT-4285
> URL: https://issues.apache.org/jira/browse/THRIFT-4285
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler, Go - Library
> Reporter: Chris Bannister
> Assignee: Chris Bannister
> Attachments: 0001-go-pull-generated-send-recv-into-lib-v6.patch,
> 0001-go-pull-generated-send-recv-into-lib-v7.patch
>
>
> Currently it is difficult to change how thrift writes messages onto the
> transport because they are in the generated code. Instead the generated
> send/recv methods should be in the library. This will greatly simplify the
> client code and remove many duplicate methods whilst allowing users more
> flexibility to implement connection pools and other features such as THeader.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
