[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198614#comment-16198614
]
ASF GitHub Bot commented on THRIFT-4285:
----------------------------------------
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1382
Is there a way you can provide a generated NewFooClientFactory as an
adapter to run the new code? i.e. (sorry this isn't go, but you get the idea):
mypkg.NewFooClientFactory(transport, protocolFactory) { return
mypkg.NewFooClient(thrift.NewTStandardClient(protocolFactory.GetProtocol(transport)));
}
This would make it backwards compatible for everyone and you wouldn't need
to change any of the test files, I believe? This would be better overall for
the project to maintain backwards compatibility. Let me know what you think.
I was away for a couple days on college tours with my son, sorry for the
delay.
> Pull generated send/recv into library to allow behaviour to be customised
> -------------------------------------------------------------------------
>
> Key: THRIFT-4285
> URL: https://issues.apache.org/jira/browse/THRIFT-4285
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler, Go - Library
> Reporter: Chris Bannister
> Assignee: Chris Bannister
> Attachments: 0001-go-pull-generated-send-recv-into-lib-v6.patch,
> 0001-go-pull-generated-send-recv-into-lib-v7.patch
>
>
> Currently it is difficult to change how thrift writes messages onto the
> transport because they are in the generated code. Instead the generated
> send/recv methods should be in the library. This will greatly simplify the
> client code and remove many duplicate methods whilst allowing users more
> flexibility to implement connection pools and other features such as THeader.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
