Github user Alex-Vol commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1468#discussion_r161389720
  
    --- Diff: lib/java/gradle.properties ---
    @@ -0,0 +1,35 @@
    +# This file is shared currently between this Gradle build and the
    +# Ant builds for fd303 and JavaScript. Keep the dotted notation for
    +# the properties to minimize the changes in the dependencies.
    +thrift.version=1.0.0
    +thrift.groupid=org.apache.thrift
    +release=false
    +
    +# Local Install paths
    +install.path=/usr/local/lib
    +install.javadoc.path=/usr/local/lib
    +
    +# Test execution properties
    +testPort=9090
    +
    +# Maven dependency download locations
    +mvn.repo=http://repo1.maven.org/maven2
    +apache.repo=https://repository.apache.org/content/repositories/releases
    +
    +# Apache Maven publish
    +license=http://www.apache.org/licenses/LICENSE-2.0.txt
    
+maven-repository-url=https://repository.apache.org/service/local/staging/deploy/maven2
    +maven-repository-id=apache.releases.https
    +
    +# Ant Maven Task Jar Information, not used by this project anymore
    +mvn.ant.task.version=2.1.3
    --- End diff --
    
    This properties file is imported in the remaining Ant builds that I had not 
enough motivation to redo. The Ant builds that use this reference the JAR files 
from this project as well. IMHO this is a very poorly constructed side-channel 
that has no guarantees from what I can see to ensure the Java code has been 
built to any level before attempting to use the classes.


---

Reply via email to