Github user Alex-Vol commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1468#discussion_r161404044
  
    --- Diff: lib/java/gradle.properties ---
    @@ -0,0 +1,35 @@
    +# This file is shared currently between this Gradle build and the
    +# Ant builds for fd303 and JavaScript. Keep the dotted notation for
    +# the properties to minimize the changes in the dependencies.
    +thrift.version=1.0.0
    +thrift.groupid=org.apache.thrift
    +release=false
    +
    +# Local Install paths
    +install.path=/usr/local/lib
    +install.javadoc.path=/usr/local/lib
    +
    +# Test execution properties
    +testPort=9090
    +
    +# Maven dependency download locations
    +mvn.repo=http://repo1.maven.org/maven2
    +apache.repo=https://repository.apache.org/content/repositories/releases
    +
    +# Apache Maven publish
    +license=http://www.apache.org/licenses/LICENSE-2.0.txt
    
+maven-repository-url=https://repository.apache.org/service/local/staging/deploy/maven2
    +maven-repository-id=apache.releases.https
    +
    +# Ant Maven Task Jar Information, not used by this project anymore
    +mvn.ant.task.version=2.1.3
    --- End diff --
    
    I may try to eliminate these hold overs from the Ant build system because 
they weaken the overall build system dependency model. Each module in this 
project should be self describing independently of the rest IMHO.
    
    Unless all the Java related modules could be consolidated under a common 
Gradle driven project instead of many small separate ones. Then the publication 
details can live in a common place instead of 4-5 Ant build.xml files 
independently managed.


---

Reply via email to