On Wed, Oct 28, 2020 at 1:50 PM Duru Can Celasun <[email protected]> wrote: > > Apologies, I thought I was replying to Andrew and I only just now realize it > was Christopher. My point stands though, if there is an easier/preferred way > to do this just let me know and we'll do that.
No problem. :) [SNIP] > > I'm not a designer and I know nothing about frontend development. That's totally fine. I'm not a designer either. I was more commenting to address the "readiness" of the site. If the look/feel are okay to the Thrift PMC, then that should be enough to be "ready" to replace the existing site. I don't know where they stand (again, I'm not even a committer on the project... just offering feedback). :) [SNIP] > > That was always the intention, as stated in the original Jira issue > > [1]. In fact, I've provided build instructions that can be used by > > INFRA. As far as I'm aware, INFRA would not be the ones who need those instructions, but the Thrift committers who will be responsible for setting up the build and maintaining it. Can you link to those instructions here? I couldn't find them. Maybe I can suggest a way it can be automated. At the very least, I want to try to build it locally to see how it works. [SNIP] > > Thanks for the link. I'm not familiar with this but if INFRA could > > create a thrift-website repo for us on Github I'd be happy to take a > > look. A Thrift PMC member can create the repo themselves using the self-serve tool (http://selfserve.apache.org/). I definitely recommend having the website in a separate repo from the main code base, just because it's easier to track pull requests that way, and so people contributing to one don't have to clone all the commits for the other. [SNIP] > > I'm more than happy to do it your way, especially if you think it'd be > > easier. My one concern is that the current CMS content isn't exactly > > great and my RTD version has improvements, but we can sort that later. > > How should we proceed? Well, ultimately, the decision is up to the Thrift PMC. I can only offer suggestions and opinions, as I'm neither a PMC member nor a committer for Thrift. The CMS content may not be "great" as is, but it is what is there and working now, and its static HTML and/or basic Markdown is 99% compatible with Jekyll's Markdown, so it's easy to convert while preserving the existing site look and feel... just to get off of CMS as quickly as possible. However, since I'm not a committer for Thrift, there's little I can do to actually make it happen. *IF* the PMC wants to go that route to get things done quickly, I can convert over the Markdown this week, and put it in my own repo for them to use directly, but I don't want to do that effort if that's not what they want to do. If they want to go with readthedocs to replace the site look and feel at the same time as getting off of CMS (rather than two steps), then I'd rather spend my effort trying to help you (since you're a PMC member working on this) get the builds automated and an .asf.yaml file in place to trigger the publication. Gavin also suggested another option, which would basically be doing *both* options... a regular site and a readthedocs site with a docs.thrift.apache.org CNAME. If that's the route that the PMC wants to do, then it makes sense to just deal with converting over the CMS content as I suggested first, and then working on getting the readthedocs site on the CNAME after that. Whatever the PMC wants to do, the sooner it is decided, the more I can help make it happen as a mere contributor. :) Christopher
