Ok, we should be up to date and we can close all PR...but applying them is really not as easy as it should. I wouldn't ask guys to do PR while we can apply it to main (svn today) directly.
Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-04-19 18:42 GMT+02:00 Romain Manni-Bucau <rmannibu...@gmail.com>: > well would be awesome to have PRs...but would be great to be able to > apply them. Maybe time to migrate to git cause git-svn is just a pain. > > > Romain Manni-Bucau > Twitter: @rmannibucau > Blog: http://rmannibucau.wordpress.com/ > LinkedIn: http://fr.linkedin.com/in/rmannibucau > Github: https://github.com/rmannibucau > > > 2014-04-19 18:19 GMT+02:00 Ivan St. Ivanov <ivan.st.iva...@gmail.com>: >> Hey folks! >> >> Before you start reviewing and merging, maybe it's a good idea for everyone >> of us that has submitted a pull request, to review it. When I did mine, I >> didn't know that the official path to contribute something was SVN patches. >> So after I understood that, I made the same change as SVN patch and it was >> merged. That is why I just closed my pull request. Maybe everyone that >> knows that their pull request was then merged as SVN patch, should do the >> same. >> >> Cheers, >> Ivan >> >> >> On Sat, Apr 19, 2014 at 1:33 AM, Alan Cabrera <l...@toolazydogs.com> wrote: >> >>> >>> On Apr 18, 2014, at 3:07 PM, David Blevins <david.blev...@gmail.com> >>> wrote: >>> >>> > This is probably not the full list of patches yet to be applied, but a >>> definite good start: >>> > >>> > - https://github.com/apache/tomee/pulls >>> > >>> > Andy or anyone else, possible to get some of these cleared out? The >>> ASF-Github integration now puts full details on how to deal with external >>> pull requests in the related JIRA: >>> > >>> > - >>> https://issues.apache.org/jira/browse/TOMEE-1154?focusedCommentId=13974390&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13974390 >>> > >>> > I'm pretty excited about this improved integration. It has historically >>> been very hard to track patches in a JIRA with a few thousand items. An >>> actual queue of patch "TODOs" can really do us some good. >>> >>> Some of the above pull requests don't seem to have a handy comment a to >>> what to do and some have no corresponding Jira. Do we just review and >>> commit? >>> >>> >>> Regards, >>> Alan >>> >>>
