What approach did you take? The patch approach should be the same as svn: - https://github.com/apache/tomee/pull/6.patch
On Apr 20, 2014, at 1:08 PM, Romain Manni-Bucau <rmannibu...@gmail.com> wrote: > It was but svn/git doesnt work together well enough to have it working > well. If we were on git it would be nice. > Le 20 avr. 2014 20:44, "David Blevins" <david.blev...@gmail.com> a écrit : > >> I think when you submitted your patch the asf hadn't yet improved the >> github integration. Daniel Gruno (@Humbedooh) has put a lot of work into >> and would probably do more if we had more ideas for him. >> >> >> -David >> >> On Apr 19, 2014, at 9:19 AM, Ivan St. Ivanov <ivan.st.iva...@gmail.com> >> wrote: >> >>> Hey folks! >>> >>> Before you start reviewing and merging, maybe it's a good idea for >> everyone >>> of us that has submitted a pull request, to review it. When I did mine, I >>> didn't know that the official path to contribute something was SVN >> patches. >>> So after I understood that, I made the same change as SVN patch and it >> was >>> merged. That is why I just closed my pull request. Maybe everyone that >>> knows that their pull request was then merged as SVN patch, should do the >>> same. >>> >>> Cheers, >>> Ivan >>> >>> >>> On Sat, Apr 19, 2014 at 1:33 AM, Alan Cabrera <l...@toolazydogs.com> >> wrote: >>> >>>> >>>> On Apr 18, 2014, at 3:07 PM, David Blevins <david.blev...@gmail.com> >>>> wrote: >>>> >>>>> This is probably not the full list of patches yet to be applied, but a >>>> definite good start: >>>>> >>>>> - https://github.com/apache/tomee/pulls >>>>> >>>>> Andy or anyone else, possible to get some of these cleared out? The >>>> ASF-Github integration now puts full details on how to deal with >> external >>>> pull requests in the related JIRA: >>>>> >>>>> - >>>> >> https://issues.apache.org/jira/browse/TOMEE-1154?focusedCommentId=13974390&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13974390 >>>>> >>>>> I'm pretty excited about this improved integration. It has >> historically >>>> been very hard to track patches in a JIRA with a few thousand items. An >>>> actual queue of patch "TODOs" can really do us some good. >>>> >>>> Some of the above pull requests don't seem to have a handy comment a to >>>> what to do and some have no corresponding Jira. Do we just review and >>>> commit? >>>> >>>> >>>> Regards, >>>> Alan >>>> >>>> >> >>
