Ok, I’ve figured out the NOTICE file issue. Apparently, we have duplicate places where we need to place the files. One in the webapp module and another one in the dist module :(
Here is a PR to fix the issue: https://github.com/apache/tomee/pull/158 <https://github.com/apache/tomee/pull/158> I would suggest that instead of a full reroll, we update the TAG with this change and redeploy only the MP dist binary. Not sure if this is allowed :) Cheers, Roberto > On 31 Aug 2018, at 22:31, Roberto Cortez <[email protected]> wrote: > > I was writing some MP sample app cases that we can use. > > Or are you referring to something else? > > >> On 31 Aug 2018, at 16:00, Jonathan Gallimore <[email protected]> >> wrote: >> >> Roberto - did you have a test/sample app for this? >> >> Looks like the microprofile zip is short of a NOTICE file, and that would >> need to include the same notices as webprofile, plus this one: >> >> ( >> https://bitbucket.org/b_c/jose4j/src/7f9624414a1baf752adbc61d4a1be16253eeec23/NOTICE.txt?at=master&fileviewer=file-view-default >> ) >> ----- >> jose4j >> Copyright 2012-2015 Brian Campbell >> >> EcdsaUsingShaAlgorithm contains code for converting the concatenated >> R & S values of the signature to and from DER, which was originally >> derived from the Apache Santuario XML Security library's SignatureECDSA >> implementation. http://santuario.apache.org/ >> >> The Base64 implementation in this software was derived from the >> Apache Commons Codec project. >> http://commons.apache.org/proper/commons-codec/ >> >> JSON processing in this software was derived from the JSON.simple toolkit. >> https://code.google.com/p/json-simple/ >> ----- >> >> Thoughts? >> >> Other than that I can't see any issues. >> >> Jon >> >> >> On Fri, Aug 31, 2018 at 2:39 PM Jean-Louis Monteiro < >> [email protected]> wrote: >> >>> +1 >>> >>> Thank you very much Jon for the release and Roberto for the microprofile >>> work >>> >>> -- >>> Jean-Louis Monteiro >>> http://twitter.com/jlouismonteiro >>> http://www.tomitribe.com >>> >>> On Fri, Aug 31, 2018 at 1:33 PM, Mark Struberg <[email protected]> >>> wrote: >>> >>>> +1 >>>> >>>> LieGrue, >>>> strub >>>> >>>> >>>>> Am 30.08.2018 um 12:24 schrieb Jonathan Gallimore < >>>> [email protected]>: >>>>> >>>>> Hi Everyone, >>>>> >>>>> Here is the first roll of TomEE 7.1.0. Please can you take a look and >>>>> vote? Everyone, >>>>> committer or not, is encouraged to test and vote. >>>>> >>>>> Staging repo: >>>>> https://repository.apache.org/content/repositories/orgapachetomee-1119 >>>>> >>>>> Source zip: >>>>> https://repository.apache.org/content/repositories/ >>>> orgapachetomee-1119/org/apache/tomee/tomee-project/7. >>>> 1.0/tomee-project-7.1.0-source-release.zip >>>>> >>>>> Dist area: >>>>> https://dist.apache.org/repos/dist/dev/tomee/staging-1119/ >>>>> >>>>> Legal: >>>>> https://dist.apache.org/repos/dist/dev/tomee/staging-1119/legal.zip >>>>> >>>>> Keys: >>>>> https://dist.apache.org/repos/dist/release/tomee/KEYS >>>>> >>>>> Please vote: >>>>> +1: Release >>>>> -1 Do not release because ... >>>>> >>>>> The vote will be open for 3 days or the consensus is binding (At least >>> 3 >>>>> binding votes). >>>>> >>>>> Many thanks >>>>> >>>>> Jon >>>> >>>> >>> >
