I can re-roll it to include this, but as I write this, the maven release:perform literally just completed. For visibility, going as fast as I can, its a good 2 hours each time I do this.
The release has been open for comment for a few days, and prior to that I put up a preview release which didn't get much feedback. Prior to that, I posted saying we were going to do the release - so there was opportunity to discuss the content of the release. I'm going to drop and rollback the release and wait 24-48 hours before starting again to allow the community to discuss where to go from here. Can you confirm that 7.1.0 works with Java 11 with this patch? Certainly it looked like other dependencies needed update and hadn't finished my own testing. I merged that PR in as it moved us forward. While I appreciate the importance of the Java 11 support to you - this was only supposed to be a simple re-roll to correct a legal issue. Now we have multiple other changes going in. We all want faster, more rapid releases. If we keep halting releases to slip in more patches, I suspect keeping up release cadence will be hard, and I'll personally probably end up spending more time rolling releases than actually fixing issues. My preference would be to keep going and simply release far more often with much smaller deltas. Hope that makes sense. Jon On Sun, Sep 2, 2018 at 10:12 PM Alex The Rocker <alex.m3...@gmail.com> wrote: > Hello Jon, > > Any reason why TomEE 7.1 wouldn't include the PR proposed in this JIRA > https://issues.apache.org/jira/browse/TOMEE-2200 to make it compatible > with Java 11 (which will be officially be released this month) ? > > Thanks, > Alexandre > > Le dim. 2 sept. 2018 à 22:14, Jonathan Gallimore > <jonathan.gallim...@gmail.com> a écrit : > > > > Rerolling with Roberto's corrected NOTICE file. I'm including Thiago's > > commit as well. I'll post a new VOTE. > > > > Jon > > > > On Sun, Sep 2, 2018 at 7:44 PM Jean-Louis Monteiro < > jlmonte...@tomitribe.com> > > wrote: > > > > > A full reroll is usually faster. > > > > > > Le ven. 31 août 2018 à 23:49, Roberto Cortez > <radcor...@yahoo.com.invalid> > > > a écrit : > > > > > > > Ok, I’ve figured out the NOTICE file issue. > > > > > > > > Apparently, we have duplicate places where we need to place the > files. > > > One > > > > in the webapp module and another one in the dist module :( > > > > > > > > Here is a PR to fix the issue: > > > > https://github.com/apache/tomee/pull/158 < > > > > https://github.com/apache/tomee/pull/158> > > > > > > > > I would suggest that instead of a full reroll, we update the TAG with > > > this > > > > change and redeploy only the MP dist binary. Not sure if this is > allowed > > > :) > > > > > > > > Cheers, > > > > Roberto > > > > > > > > > On 31 Aug 2018, at 22:31, Roberto Cortez > <radcor...@yahoo.com.INVALID> > > > > wrote: > > > > > > > > > > I was writing some MP sample app cases that we can use. > > > > > > > > > > Or are you referring to something else? > > > > > > > > > > > > > > >> On 31 Aug 2018, at 16:00, Jonathan Gallimore < > > > > jonathan.gallim...@gmail.com> wrote: > > > > >> > > > > >> Roberto - did you have a test/sample app for this? > > > > >> > > > > >> Looks like the microprofile zip is short of a NOTICE file, and > that > > > > would > > > > >> need to include the same notices as webprofile, plus this one: > > > > >> > > > > >> ( > > > > >> > > > > > > > > https://bitbucket.org/b_c/jose4j/src/7f9624414a1baf752adbc61d4a1be16253eeec23/NOTICE.txt?at=master&fileviewer=file-view-default > > > > >> ) > > > > >> ----- > > > > >> jose4j > > > > >> Copyright 2012-2015 Brian Campbell > > > > >> > > > > >> EcdsaUsingShaAlgorithm contains code for converting the > concatenated > > > > >> R & S values of the signature to and from DER, which was > originally > > > > >> derived from the Apache Santuario XML Security library's > > > SignatureECDSA > > > > >> implementation. http://santuario.apache.org/ > > > > >> > > > > >> The Base64 implementation in this software was derived from the > > > > >> Apache Commons Codec project. > > > > >> http://commons.apache.org/proper/commons-codec/ > > > > >> > > > > >> JSON processing in this software was derived from the JSON.simple > > > > toolkit. > > > > >> https://code.google.com/p/json-simple/ > > > > >> ----- > > > > >> > > > > >> Thoughts? > > > > >> > > > > >> Other than that I can't see any issues. > > > > >> > > > > >> Jon > > > > >> > > > > >> > > > > >> On Fri, Aug 31, 2018 at 2:39 PM Jean-Louis Monteiro < > > > > >> jlmonte...@tomitribe.com> wrote: > > > > >> > > > > >>> +1 > > > > >>> > > > > >>> Thank you very much Jon for the release and Roberto for the > > > > microprofile > > > > >>> work > > > > >>> > > > > >>> -- > > > > >>> Jean-Louis Monteiro > > > > >>> http://twitter.com/jlouismonteiro > > > > >>> http://www.tomitribe.com > > > > >>> > > > > >>> On Fri, Aug 31, 2018 at 1:33 PM, Mark Struberg > > > > <strub...@yahoo.de.invalid> > > > > >>> wrote: > > > > >>> > > > > >>>> +1 > > > > >>>> > > > > >>>> LieGrue, > > > > >>>> strub > > > > >>>> > > > > >>>> > > > > >>>>> Am 30.08.2018 um 12:24 schrieb Jonathan Gallimore < > > > > >>>> jonathan.gallim...@gmail.com>: > > > > >>>>> > > > > >>>>> Hi Everyone, > > > > >>>>> > > > > >>>>> Here is the first roll of TomEE 7.1.0. Please can you take a > look > > > and > > > > >>>>> vote? Everyone, > > > > >>>>> committer or not, is encouraged to test and vote. > > > > >>>>> > > > > >>>>> Staging repo: > > > > >>>>> > > > > > https://repository.apache.org/content/repositories/orgapachetomee-1119 > > > > >>>>> > > > > >>>>> Source zip: > > > > >>>>> https://repository.apache.org/content/repositories/ > > > > >>>> orgapachetomee-1119/org/apache/tomee/tomee-project/7. > > > > >>>> 1.0/tomee-project-7.1.0-source-release.zip > > > > >>>>> > > > > >>>>> Dist area: > > > > >>>>> https://dist.apache.org/repos/dist/dev/tomee/staging-1119/ > > > > >>>>> > > > > >>>>> Legal: > > > > >>>>> > > > https://dist.apache.org/repos/dist/dev/tomee/staging-1119/legal.zip > > > > >>>>> > > > > >>>>> Keys: > > > > >>>>> https://dist.apache.org/repos/dist/release/tomee/KEYS > > > > >>>>> > > > > >>>>> Please vote: > > > > >>>>> +1: Release > > > > >>>>> -1 Do not release because ... > > > > >>>>> > > > > >>>>> The vote will be open for 3 days or the consensus is binding > (At > > > > least > > > > >>> 3 > > > > >>>>> binding votes). > > > > >>>>> > > > > >>>>> Many thanks > > > > >>>>> > > > > >>>>> Jon > > > > >>>> > > > > >>>> > > > > >>> > > > > > > > > > > > > > > > > >
