Hi Hayri, Welcome back, since the current master is Java 8 compliant [1], I think both PR's are good improvements to code clean up.
[1] https://github.com/apache/tomee/blob/master/pom.xml#L98-L99 El vie., 30 nov. 2018 a las 13:12, Hayri Cicek (<[email protected]>) escribió: > Hi everyone, > > My name is Hayri Cicek and we use TomEE everyday where I work and would > love to contribute back to the project and > I saw the how can I help and would love to try help but I started trying to > contribute about 3 month ago and have 2 PR's where I did some final > parameters and use of diamond operator and would love to see if the PR's > are okej or if not then I would love to help with something else 😊 > > Links to PR's > https://github.com/apache/tomee/pull/168 > > https://github.com/apache/tomee/pull/163 > > Best regards > Hayri Cicek > https://kodnito.com > -- Atentamente: César Hernández Mendoza.
