Hi César and Hayri, I very much support César's suggestion to open a JIRA issue per PR (or even upfront so others can comment or point you to existing resources early). Thereby, other devs might better check which branches or what parts of TomEE are affected, or what the intention of an improvement is.
Best, mawiesne -- https://twitter.com/mawiesne <https://twitter.com/mawiesne> > Am 30.11.2018 um 23:17 schrieb César Hernández Mendoza <[email protected]>: > > btw, Hayri, I recommend you to create a Jira for your Pr's. [1] > Base on my experience, it's better to have this tracking so you can then > see the status of your PR (in a review, assigned, etc). > > > [1] https://issues.apache.org/jira/projects/TOMEE/summary > > El vie., 30 nov. 2018 a las 16:13, Hayri Cicek (<[email protected]>) > escribió: > >> Thanks César >> >> Den fre 30 nov. 2018 20:40 skrev César Hernández Mendoza < >> [email protected]>: >> >>> Hi Hayri, >>> >>> Welcome back, since the current master is Java 8 compliant [1], I think >>> both PR's are good improvements to code clean up. >>> >>> >>> [1] https://github.com/apache/tomee/blob/master/pom.xml#L98-L99 >>> >>> El vie., 30 nov. 2018 a las 13:12, Hayri Cicek (<[email protected]>) >>> escribió: >>> >>>> Hi everyone, >>>> >>>> My name is Hayri Cicek and we use TomEE everyday where I work and would >>>> love to contribute back to the project and >>>> I saw the how can I help and would love to try help but I started >> trying >>> to >>>> contribute about 3 month ago and have 2 PR's where I did some final >>>> parameters and use of diamond operator and would love to see if the >> PR's >>>> are okej or if not then I would love to help with something else 😊 >>>> >>>> Links to PR's >>>> https://github.com/apache/tomee/pull/168 >>>> >>>> https://github.com/apache/tomee/pull/163 >>>> >>>> Best regards >>>> Hayri Cicek >>>> https://kodnito.com >>>> >>> >>> >>> -- >>> Atentamente: >>> César Hernández Mendoza. >>> >> > > > -- > Atentamente: > César Hernández Mendoza.
smime.p7s
Description: S/MIME cryptographic signature
