Hey Hayri! I have reviewed PR https://github.com/apache/tomee/pull/231 related to code clean up. It was a big long to review. Next time if you could make the PRs smaller so they are easier to review and merge, that'd me great.
There is a conflict to solve and then it's ready to go. Thanks -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Dec 3, 2018 at 7:55 PM Hayri Cicek <cicekha...@gmail.com> wrote: > Thanks Richard > > Den mĂ„n 3 dec. 2018 kl 13:24 skrev Richard Monson-Haefel < > monsonhae...@gmail.com>: > > > Welcome to TomEE, Hayri! > > > > On Fri, Nov 30, 2018 at 1:12 PM Hayri Cicek <cicekha...@gmail.com> > wrote: > > > > > Hi everyone, > > > > > > My name is Hayri Cicek and we use TomEE everyday where I work and would > > > love to contribute back to the project and > > > I saw the how can I help and would love to try help but I started > trying > > to > > > contribute about 3 month ago and have 2 PR's where I did some final > > > parameters and use of diamond operator and would love to see if the > PR's > > > are okej or if not then I would love to help with something else đ > > > > > > Links to PR's > > > https://github.com/apache/tomee/pull/168 > > > > > > https://github.com/apache/tomee/pull/163 > > > > > > Best regards > > > Hayri Cicek > > > https://kodnito.com > > > > > > > > > -- > > Richard Monson-Haefel > > https://twitter.com/rmonson > > https://www.linkedin.com/in/monsonhaefel/ > > >
