Ok Jon, I'll work on these tests.
Thanks. Em sex, 7 de dez de 2018 às 16:23, Jonathan Gallimore < jonathan.gallim...@gmail.com> escreveu: > Thanks Dani. > > That's right, and these two as well: > > XMLConfigurationTest > - XMLConfiguredConstraintValidatorTest > > On Fri, 7 Dec 2018, 18:20 Daniel Cunha <daniels...@gmail.com wrote: > > > Hey Jon, > > > > I can help with BVal tests. > > If I get it is the BVal test related DuplicateConfigurationTest right? > > > > > > Em sex, 7 de dez de 2018 às 14:03, Jonathan Gallimore < > > jonathan.gallim...@gmail.com> escreveu: > > > > > Filed a ticket: https://issues.apache.org/jira/browse/TOMEE-2330. We > > could > > > ignore the test in the meantime. > > > > > > Jon > > > > > > On Fri, Dec 7, 2018 at 4:36 PM Jonathan Gallimore < > > > jonathan.gallim...@gmail.com> wrote: > > > > > > > I committed a fix for CustomOrmXmlTest. The failure in > CmpMappingsTest > > > > actually looks like a genuine error case that only affects > > > > Plume/EclipseLink. I'm digging in. > > > > > > > > Does someone want to take the BVal tests off me? Not required, but if > > > > someone is looking for something to do, I'm happy to hand those > over, I > > > > haven't made any real progress with them. > > > > > > > > Jon > > > > > > > > On Fri, Dec 7, 2018 at 11:08 AM Jonathan Gallimore < > > > > jonathan.gallim...@gmail.com> wrote: > > > > > > > >> I see this also fails on > > > >> buildbot: > > > org.apache.openejb.arquillian.tests.cmp.sample.CustomOrmXmlTest - > > > >> its a simple fix which I'll commit now. > > > >> > > > >> Jon > > > >> > > > >> On Fri, Dec 7, 2018 at 11:05 AM Jonathan Gallimore < > > > >> jonathan.gallim...@gmail.com> wrote: > > > >> > > > >>> Hey Jean-Louis > > > >>> > > > >>> Thanks for the list! > > > >>> > > > >>> These ones _should_ be fixed (as of late yesterday) > > > >>> > > > >>> - LegacyServerTest > > > >>> - LegacyClientTest > > > >>> - (StickyConnection|RoundRobin|Random)StrategyTest > > > >>> - ReconnectDelayCaseInsensitiveTest > > > >>> - ReconnectDelayListSelfTest > > > >>> - ReconnectTest > > > >>> > > > >>> Its possible you didn't have my changes. > > > >>> > > > >>> I'm currently looking at these two: > > > >>> > > > >>> - XMLConfigurationTest > > > >>> - XMLConfiguredConstraintValidatorTest > > > >>> > > > >>> I also get a failure > > > >>> in org.apache.openejb.arquillian.tests.cmp.CmpMappingTest, which I > > > wrote, > > > >>> so I'll take a quick look at that. > > > >>> > > > >>> Cheers > > > >>> > > > >>> Jon > > > >>> > > > >>> On Fri, Dec 7, 2018 at 10:59 AM Jean-Louis Monteiro < > > > >>> jlmonte...@tomitribe.com> wrote: > > > >>> > > > >>>> I have been digging and running tests locally. > > > >>>> Here is the list of tests failures I have extracted. > > > >>>> > > > >>>> - JMSInjectionTest > > > >>>> - CDIInvokeSimpleGetOperationTest > > > >>>> - CDIInvokeWithRegisteredProviderTest > > > >>>> - FeatureRegistrationTest > > > >>>> - InvokeWithJsonProviderTest > > > >>>> - DuplicateConfigurationTest > > > >>>> - XMLConfigurationTest > > > >>>> - XMLConfiguredConstraintValidatorTest > > > >>>> - MoviesArquillianHtmlUnitTest > > > >>>> - DeployInWebAppsDirectoryTest > > > >>>> - LegacyServerTest > > > >>>> - LegacyClientTest > > > >>>> - (StickyConnection|RoundRobin|Random)StrategyTest > > > >>>> - ReconnectDelayCaseInsensitiveTest > > > >>>> - ReconnectDelayListSelfTest > > > >>>> - ReconnectTest > > > >>>> > > > >>>> Anything else I missed? > > > >>>> > > > >>>> -- > > > >>>> Jean-Louis Monteiro > > > >>>> http://twitter.com/jlouismonteiro > > > >>>> http://www.tomitribe.com > > > >>>> > > > >>>> > > > >>>> On Thu, Dec 6, 2018 at 11:43 PM Jonathan Gallimore < > > > >>>> jonathan.gallim...@gmail.com> wrote: > > > >>>> > > > >>>> > I've merged a few PRs in which appear to have kept the build in > > the > > > >>>> same > > > >>>> > state. I also fixed up the itest failures. I'll work on bval > > > >>>> tomorrow. I > > > >>>> > get failures with the MicroProfile REST client locally, so if > > > someone > > > >>>> can > > > >>>> > take a look at that, that would be great. > > > >>>> > > > > >>>> > Thanks > > > >>>> > > > > >>>> > Jon > > > >>>> > > > > >>>> > On Tue, Dec 4, 2018 at 10:25 PM Roberto Cortez > > > >>>> <radcor...@yahoo.com.invalid > > > >>>> > > > > > >>>> > wrote: > > > >>>> > > > > >>>> > > Hi folks, > > > >>>> > > > > > >>>> > > It is great to see so many contributions and we hope to > continue > > > >>>> and even > > > >>>> > > increase the traffic. > > > >>>> > > > > > >>>> > > Now, this also comes with a few challenges. Our build has been > > red > > > >>>> for a > > > >>>> > > while and I would like to get it green again: > > > >>>> > > > > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35 > > > >>>> < > > > >>>> > > > > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35 > > > >>>> > > > > >>>> > > > > > >>>> > > The latest build has some checkstyle violations and test > > failures: > > > >>>> > > > > > >>>> > > > > > >>>> > > > > >>>> > > > > > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio > > > >>>> > > < > > > >>>> > > > > > >>>> > > > > >>>> > > > > > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio > > > >>>> > > > > > > >>>> > > > > > >>>> > > > > > >>>> > > > > >>>> > > > > > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio > > > >>>> > > < > > > >>>> > > > > > >>>> > > > > >>>> > > > > > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio > > > >>>> > > > > > > >>>> > > > > > >>>> > > It would be great if someone could pick these issues and fix > > them > > > >>>> and we > > > >>>> > > should prioritize any build fixing PR above everything else. > > > >>>> > > > > > >>>> > > Also, when someone sends a PR, your work doesn’t end when it > > gets > > > >>>> merged. > > > >>>> > > Running a full build takes almost 5 hours, so the committer > most > > > of > > > >>>> the > > > >>>> > > times is not able to run the entire build to check your PR. I > > > >>>> kindly ask > > > >>>> > > you to monitor the tomee build bot here: > > > >>>> > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8 < > > > >>>> > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8> after > > > your > > > >>>> PR > > > >>>> > > gets merged and if you uncover something wrong, please send a > > > >>>> corrective > > > >>>> > PR. > > > >>>> > > > > > >>>> > > I’ll be out the next couple of days, so I hope someone can > pick > > > >>>> this up > > > >>>> > :) > > > >>>> > > > > > >>>> > > Cheers, > > > >>>> > > Roberto > > > >>>> > > > > >>>> > > > >>> > > > > > > > > > -- > > Daniel "soro" Cunha > > https://twitter.com/dvlc_ > > > -- Daniel "soro" Cunha https://twitter.com/dvlc_
