Hi all, here’s my
+1 (non-binding) Tested with several projects (primarily web services, JAXB, REST…), both on Linux & Mac OS, each under AdoptOpenJDK 11 (latest). => no show stoppers found. Best Martin — https://twitter.com/mawiesne <https://twitter.com/mawiesne> > Am 23.07.2020 um 17:02 schrieb Jean-Louis Monteiro <[email protected]>: > > Hey Jon. > > Did some quick tests and ran TCK. No regression, we even fixed some good > chunk of tests for better TCK coverage. > > +1 > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Thu, Jul 23, 2020 at 3:29 PM Vicente Rossello <[email protected]> > wrote: > >> Hi, >> >> I've checked the artifacts and played a bit with the plus server. >> >> +1 >> >> On Thu, Jul 23, 2020 at 2:58 PM Zowalla, Richard < >> [email protected]> wrote: >> >>> Thanks for the exaplantion, Jon. I will take a look at the transformer >>> and apply it to our application after I have returned from vacation. >>> >>> For now: >>> >>> Take my +1 (although I've only tested 8.0.4 as stated in my original >>> mail). >>> >>> Am Donnerstag, den 23.07.2020, 12:41 +0100 schrieb Jonathan Gallimore: >>> >>> Hi Richard >>> >>> >>> The artifacts are here: >>> >>> https://repository.apache.org/content/repositories/orgapachetomee-1173/org/apache/tomee/jakarta/apache-tomee/9.0.0-M2/ >>> >>> >>> (note the org.apache.tomee.jakarta group ID). >>> >>> >>> The transformation tool currently only works on zips, which is why we don't >>> >>> (yet) have tar.gzs there. >>> >>> >>> Its worth taking a look at the Eclipse Transformer to transform your >>> >>> applications. This is another case where I'd expect issues, and encourage >>> >>> you to report them. I'm also a committer on that project and would be keen >>> >>> to help with any improvements. Here's how we do it on Moviefun: >>> >>> https://github.com/apache/tomee/blob/master/examples/moviefun/pom.xml#L111-L126 >>> >>> . >>> >>> >>> We're not able to translate javax -> jakarta "on the fly". I have looked at >>> >>> this, and theoretically its possible to create a java agent to do this, but >>> >>> it comes unstuck where various libraries inspect classes for annotations, >>> >>> and none of them actually *load* the class to do that (so it doesn't get >>> >>> translated, and subsequently fails). Unfortunately, the renaming means >>> >>> we'll all need to make changes to our applications at some point. >>> >>> >>> Jon >>> >>> >>> On Thu, Jul 23, 2020 at 12:04 PM Zowalla, Richard < >>> >>> [email protected]> wrote: >>> >>> >>> Hi Jon, >>> >>> >>> thanks for the explanation. >>> >>> >>> The artifacts for 9.0.0-M2 seem to be missing in the Maven staging >>> >>> repository? Is this known/planned in this way? >>> >>> >>> I just wanted to build our project (which works fine with 8.0.4) with >>> >>> the 9.0.0-M2 artifacts. >>> >>> >>> Thanks, >>> >>> Richard >>> >>> >>> >>> Am Donnerstag, den 23.07.2020, 10:39 +0100 schrieb Jonathan Gallimore: >>> >>> Dammit, accidentally hit send far too soon. Here's the whole message: >>> >>> >>> >>> Hi folks >>> >>> >>> Thanks for the reviews and feedback so far. >>> >>> >>> I've seen a couple of comments come in that I just wanted to >>> >>> briefly address. >>> >>> >>> The vote is TomEE 8.0.4 *and* 9.0.0-M2. A +1 is a +1 for both. You >>> >>> can't >>> >>> vote +1 for 8.0.4 and 0 (or abstain) for 9.0.0-M2, for example. I can >>> >>> cancel this vote, re-roll, and issue a separate vote for the 2, if we >>> >>> wish. >>> >>> I didn't do this on this occasion, because we're producing the binary >>> >>> that >>> >>> uses javax (8.0.4) and then transforming it to produce the version >>> >>> that >>> >>> uses jakarta (9.0.0-M2), but can do so going forward. >>> >>> >>> We don't expect 9.0.0-M2 to be perfect. We're grateful if you can >>> >>> report >>> >>> issues you find, but that shouldn't necessarily block the release. I >>> >>> totally understand that migrating your own projects to the jakarta >>> >>> namespace is a big deal and unlikely to be feasible for a vote. If >>> >>> you can >>> >>> check you can download it and boot it up, and check for any legal >>> >>> issues, >>> >>> bad libraries etc, that helps. If you'd like an example app to try, >>> >>> do try >>> >>> building the moviefun example. That (like many of the examples) >>> >>> produces >>> >>> both javax and jakarta .war files. >>> >>> >>> Jean-Louis is going to run the TCK against this, which is fantastic. >>> >>> A >>> >>> couple of notes here to set expectations - I'm not expecting a full >>> >>> pass, >>> >>> but I'm also not expecting regressions, so passing the TCK shouldn't >>> >>> block >>> >>> the release. I did have to comment out the new security module (sorry >>> >>> - >>> >>> there were some JAX-RS test failures with it), so those tests still >>> >>> won't >>> >>> pass. >>> >>> >>> Hope that all makes sense, but please ask any questions you may have. >>> >>> Many >>> >>> thanks again for your reviews. >>> >>> >>> Jon >>> >>> >>> On Thu, Jul 23, 2020 at 10:30 AM Jonathan Gallimore < >>> >>> [email protected]> wrote: >>> >>> >>> Hi folks >>> >>> >>> Thanks for the reviews and feedback so far. >>> >>> >>> I've seen a couple of comments come in that I just wanted to >>> >>> briefly address. >>> >>> >>> The vote is TomEE 8.0.4 *and* 9.0.0-M2. A +1 is a +1 for both. You >>> >>> can't >>> >>> vote +1 for 8.0.4 and 0 (or abstain) for 9.0.0-M2, for example. I >>> >>> can close >>> >>> this vote, re-roll, and issue a separate vote for the 2, if we >>> >>> wish. >>> >>> >>> I didn't, because we're producing the binary that uses javax >>> >>> (8.0.4) and >>> >>> then transforming it to produce the version that uses jakarta >>> >>> (9.0.0-M2). >>> >>> >>> On Wed, Jul 22, 2020 at 3:34 PM Jonathan Gallimore < >>> >>> [email protected]> wrote: >>> >>> >>> Hi All, >>> >>> >>> I am delighted to present a vote for Apache TomEE 9.0.0-M2 and >>> >>> Apache >>> >>> TomEE 8.0.4. >>> >>> >>> >>> Maven Repo: >>> >>> >>> https://repository.apache.org/content/repositories/orgapachetomee-1173/ >>> >>> >>> Binaries & Source: >>> >>> >>> https://dist.apache.org/repos/dist/dev/tomee/staging-1173/tomee-8.0.4/ >>> >>> >>> Source code: >>> >>> TomEE 8.0.4: >>> >>> >>> https://dist.apache.org/repos/dist/dev/tomee/staging-1173/tomee-8.0.4/tomee-project-8.0.4-source-release.zip >>> >>> TomEE Jakarta Conversion for 9.0.0-M2: >>> >>> >>> https://dist.apache.org/repos/dist/dev/tomee/staging-1173/tomee-8.0.4/apache-tomee-9.0.0-M2-source-release.zip >>> >>> >>> Tags: >>> >>> >>> >>> >>> https://gitbox.apache.org/repos/asf?p=tomee.git;a=tag;h=refs/tags/tomee-project-8.0.4 >>> >>> >>> >>> https://gitbox.apache.org/repos/asf?p=tomee-jakarta.git;a=tag;h=refs/tags/tomee-9.0.0-M2 >>> >>> >>> Release notes: >>> >>> >>> >>> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312320&version=12348414 >>> >>> >>> Please VOTE: >>> >>> >>> [+1] Yes, release it >>> >>> [+0] Not fussed >>> >>> [-1] Don't release, there's a showstopper (please specify what >>> >>> the >>> >>> showstopper is) >>> >>> >>> Vote will be open for 72 hours. >>> >>> >>> Here is my +1. >>> >>> >>> Thanks >>> >>> >>> Jon >>> >>> >>> >>> --
smime.p7s
Description: S/MIME cryptographic signature
