On Fri, Oct 19, 2018 at 12:14 PM Dewayne Richardson <[email protected]> wrote: > > I'm -1 until someone tests out the downgrade scenarios. My vote would be > to keep the goose-like downgrade options (and potentially improve db/ > admin.pl if needed to allow more rollback options if needed).
Can you elaborate on what kind of testing of downgrade scenarios you'd like to see? Ideally, I think we need to at least run SQL upgrade migrations on every PR submitted (if the PR doesn't have an upgrade migration, the test would still just run all the pre-existing ones), followed by N SQL downgrade migrations (N=number of migrations added in the PR). This should be a jenkins job that spins up a postgres docker container with the "Kabletown" data then runs the upgrade+downgrade migrations. If the migrations fail, the PR tests fail. This would give us somewhat of a guarantee that the SQL migrations actually run. - Rawlin
