Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82098461
--- Diff:
twill-common/src/main/java/org/apache/twill/internal/Constants.java ---
@@ -82,6 +82,14 @@ private Files() {
}
}
+ /**
+ * Constants for logLevel system messages.
+ */
+ public static final class SystemMessages {
--- End diff --
Why need string constants here? All system messages/commands should be
defined in `SystemMessages`. You can use object comparison instead of string
comparison.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
