Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82098323
--- Diff:
twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunResources.java
---
@@ -90,8 +104,21 @@ public Integer getDebugPort() {
}
@Override
- public Level getLogLevel() {
- return logLevel;
+ public Level getRootLogLevel() {
+ return rootLogLevel;
+ }
+
+ @Override
+ public Map<String, LogEntry.Level> getLogLevelArguments() {
+ return logLevelArguments;
+ }
+
+ @Override
+ public void updateLogLevel(Map<String, Level> logLevelArguments) {
--- End diff --
Better keep this class immutable. If there is a change in the log level,
simply create a new instance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
