Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82098021
--- Diff:
twill-api/src/main/java/org/apache/twill/api/TwillRunResources.java ---
@@ -59,6 +61,16 @@
/**
* @return the enabled log level for the container where the runnable is
running in.
*/
- LogEntry.Level getLogLevel();
+ LogEntry.Level getRootLogLevel();
+
+ /**
+ * @return the enabled log level arguments for the container where the
runnable is running in.
+ */
+ Map<String, LogEntry.Level> getLogLevelArguments();
+ /**
+ * Update the log level arguments for the container where the runnable
is running in.
+ * @param logLevelArguments
+ */
+ void updateLogLevel(Map<String, LogEntry.Level> logLevelArguments);
--- End diff --
Why there is an update method? This interface is supposedly for reporting,
hence is immutable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
