Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82098631
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java
---
@@ -137,7 +138,7 @@ public final synchronized ServiceDiscovered
discoverService(String serviceName)
@Override
public final ListenableFuture<Set<String>> restartInstances(Map<String,
- ? extends Set<Integer>> runnableToInstanceIds) {
+ ? extends Set<Integer>> runnableToInstanceIds) {
--- End diff --
This new line is awkward, even in the old code. The parent actually returns
`Future` instead of returning `ListenableFuture`. If you change the return type
to `Future`, everything should fits on one line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
