[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550443#comment-15550443
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82098461
--- Diff:
twill-common/src/main/java/org/apache/twill/internal/Constants.java ---
@@ -82,6 +82,14 @@ private Files() {
}
}
+ /**
+ * Constants for logLevel system messages.
+ */
+ public static final class SystemMessages {
--- End diff --
Why need string constants here? All system messages/commands should be
defined in `SystemMessages`. You can use object comparison instead of string
comparison.
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
