[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550441#comment-15550441
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82098631
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java
---
@@ -137,7 +138,7 @@ public final synchronized ServiceDiscovered
discoverService(String serviceName)
@Override
public final ListenableFuture<Set<String>> restartInstances(Map<String,
- ? extends Set<Integer>> runnableToInstanceIds) {
+ ? extends Set<Integer>> runnableToInstanceIds) {
--- End diff --
This new line is awkward, even in the old code. The parent actually returns
`Future` instead of returning `ListenableFuture`. If you change the return type
to `Future`, everything should fits on one line.
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
