[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550432#comment-15550432
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82098229
--- Diff:
twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunResources.java
---
@@ -30,17 +35,26 @@
private final int memoryMB;
private final String host;
private final Integer debugPort;
- private final Level logLevel;
+ private final Map<String, LogEntry.Level> logLevelArguments;
+ private Level rootLogLevel;
+
+ public DefaultTwillRunResources(int instanceId, String containerId, int
cores, int memoryMB,
+ String host, Integer debugPort, Level
rootLogLevel) {
+ this(instanceId, containerId, cores, memoryMB, host, debugPort,
rootLogLevel,
+ new HashMap<String, LogEntry.Level>());
+ }
public DefaultTwillRunResources(int instanceId, String containerId, int
cores, int memoryMB,
- String host, Integer debugPort, Level
logLevel) {
+ String host, Integer debugPort,
+ Level rootLogLevel, Map<String,
LogEntry.Level> logLevelArguments) {
this.instanceId = instanceId;
this.containerId = containerId;
this.virtualCores = cores;
this.memoryMB = memoryMB;
this.host = host;
this.debugPort = debugPort;
- this.logLevel = logLevel;
+ this.rootLogLevel = rootLogLevel;
+ this.logLevelArguments = logLevelArguments;
--- End diff --
should just call `logLevels`.
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
