[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550438#comment-15550438
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82098323
--- Diff:
twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunResources.java
---
@@ -90,8 +104,21 @@ public Integer getDebugPort() {
}
@Override
- public Level getLogLevel() {
- return logLevel;
+ public Level getRootLogLevel() {
+ return rootLogLevel;
+ }
+
+ @Override
+ public Map<String, LogEntry.Level> getLogLevelArguments() {
+ return logLevelArguments;
+ }
+
+ @Override
+ public void updateLogLevel(Map<String, Level> logLevelArguments) {
--- End diff --
Better keep this class immutable. If there is a change in the log level,
simply create a new instance.
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
