[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631266#comment-15631266
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r86273964
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,44 @@
* @return A {@link Future} that will be completed when the restart
operation has been done.
*/
Future<String> restartInstances(String runnable, int instanceId, int...
moreInstanceIds);
+
--- End diff --
It's not clear to me why these need to return a future (or anything at
all). Is it to be able to communicate an error/exception in case the setting of
the log level fails? So, when it returns it is guaranteed that all runnables
have actually adapted the new log level?
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
