[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631640#comment-15631640
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r86287245
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -296,8 +298,42 @@ public TwillPreparer addSecureStore(SecureStore
secureStore) {
@Override
public TwillPreparer setLogLevel(LogEntry.Level logLevel) {
+ return setRootLogLevel(logLevel);
+ }
+
+ @Override
+ public TwillPreparer setRootLogLevel(LogEntry.Level logLevel) {
Preconditions.checkNotNull(logLevel);
this.logLevel = logLevel;
+ saveLogLevels(logLevel);
+ return this;
+ }
+
+ @Override
+ public TwillPreparer setRootLogLevel(String runnableName, LogEntry.Level
logLevel) {
+ setLogLevels(runnableName, ImmutableMap.of(Logger.ROOT_LOGGER_NAME,
logLevel));
+ return this;
+ }
+
+ @Override
+ public TwillPreparer setLogLevels(Map<String, LogEntry.Level> logLevels)
{
+ Preconditions.checkNotNull(logLevels);
+ if (logLevels.containsKey(Logger.ROOT_LOGGER_NAME)) {
+ this.logLevel = logLevels.get(Logger.ROOT_LOGGER_NAME);
+ }
+ for (String runnableName : twillSpec.getRunnables().keySet()) {
+ saveLogLevels(runnableName, logLevels);
+ }
+ return this;
+ }
+
+ @Override
+ public TwillPreparer setLogLevels(String runnableName, Map<String,
LogEntry.Level> runnableLogLeves) {
--- End diff --
typo: runnableLogLevels
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
