[ 
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631642#comment-15631642
 ] 

ASF GitHub Bot commented on TWILL-138:
--------------------------------------

Github user anew commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r86286972
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
 ---
    @@ -475,6 +496,11 @@ private void sendMessage(final String runnableName, 
final Message message,
         Futures.addCallback(controller.sendMessage(message), new 
FutureCallback<Message>() {
           @Override
           public void onSuccess(Message result) {
    +        //update log level information
    --- End diff --
    
    onSuccess here really means that the message has been sent to the runnable 
successfully, right? But it does not reflect the actual state of the runnable 
itself? It that on purpose?


> Runtime change of Application runnable log level
> ------------------------------------------------
>
>                 Key: TWILL-138
>                 URL: https://issues.apache.org/jira/browse/TWILL-138
>             Project: Apache Twill
>          Issue Type: New Feature
>          Components: core
>            Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to