[ 
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631578#comment-15631578
 ] 

ASF GitHub Bot commented on TWILL-138:
--------------------------------------

Github user yaojiefeng commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r86286137
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/internal/DefaultResourceReport.java 
---
    @@ -158,4 +174,31 @@ public String toString() {
           ", services=" + services +
           '}';
       }
    +
    +  private TwillRunResources wrapTwillRunResources(final String 
runnableName, TwillRunResources resources) {
    --- End diff --
    
    The `logLevels` for all running containers are stored in `ResourceReport`, 
and `ResourceReport` have a map containing the `TwillRunResources` for each 
running runnable. We want to return the correct log levels for each runnable. 
So we wrap the `TwillRunResources` with `ForwardingTwillRunResources`, which 
has a delegation and we override the `getLogLevels` methods to get the log 
levels from the map in `ResourceReport`.


> Runtime change of Application runnable log level
> ------------------------------------------------
>
>                 Key: TWILL-138
>                 URL: https://issues.apache.org/jira/browse/TWILL-138
>             Project: Apache Twill
>          Issue Type: New Feature
>          Components: core
>            Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to