Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87875415
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerService.java
---
@@ -56,24 +66,27 @@
public TwillContainerService(BasicTwillContext context, ContainerInfo
containerInfo, ZKClient zkClient,
RunId runId, TwillRunnableSpecification
specification, ClassLoader classLoader,
- Location applicationLocation) {
+ Location applicationLocation, Map<String,
LogEntry.Level> logLevels) {
super(zkClient, runId, applicationLocation);
this.specification = specification;
this.classLoader = classLoader;
- this.containerLiveNodeData = createLiveNodeData(containerInfo);
+ this.containerLiveNodeData = createLiveNodeData(containerInfo,
+ isLoggerContext()
+ ? logLevels :
Collections.<String, LogEntry.Level>emptyMap());
this.context = context;
}
- private ContainerLiveNodeData createLiveNodeData(ContainerInfo
containerInfo) {
+ private ContainerLiveNodeData createLiveNodeData(ContainerInfo
containerInfo,
+ Map<String,
LogEntry.Level> logLevels) {
// if debugging is enabled, log the port and register it in service
discovery.
String debugPort = System.getProperty("twill.debug.port");
if (debugPort != null) {
LOG.info("JVM is listening for debugger on port {}", debugPort);
}
return new ContainerLiveNodeData(containerInfo.getId(),
containerInfo.getHost().getCanonicalHostName(),
- debugPort);
+ debugPort, logLevels);
--- End diff --
I think we should filter out the one that has `null` value, since those are
representing reset.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
