Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r87874799
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
 ---
    @@ -575,18 +597,63 @@ private boolean removeContainerInfo(String 
containerId) {
         return false;
       }
     
    +  private void checkAndSetLogLevels(Message message, String runnableName) {
    +    String command = message.getCommand().getCommand();
    +    if (message.getType() != Message.Type.SYSTEM || 
!SystemMessages.LOG_LEVEL.equals(command)) {
    +      return;
    +    }
    +
    +    Map<String, LogEntry.Level> runnableLogLevels = 
copyAndConvertLogLevelsMap(message.getCommand().getOptions());
    +    if (!logLevels.containsKey(runnableName)) {
    +      logLevels.put(runnableName, runnableLogLevels);
    +    } else {
    +      logLevels.get(runnableName).putAll(runnableLogLevels);
    +    }
    +  }
    +
    +  private Location saveLogLevels() {
    +    LOG.debug("save the log level file");
    +    try {
    +      Gson gson = new GsonBuilder().serializeNulls().create();
    +      String jsonStr = gson.toJson(logLevels);
    +      String fileName = Hashing.md5().hashString(jsonStr) + "." + 
Constants.Files.LOG_LEVELS;
    +      Location location = applicationLocation.append(fileName);
    +      if (!location.exists()) {
    +        try (Writer writer = new 
OutputStreamWriter(location.getOutputStream(), Charsets.UTF_8)) {
    +          gson.toJson(logLevels, new TypeToken<Map<String, Map<String, 
LogEntry.Level>>>() { }.getType(), writer);
    --- End diff --
    
    Why need to encode again? You can just write the `jsonStr` to the file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to