Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r87353516
  
    --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java 
---
    @@ -89,4 +90,30 @@
        * @return A {@link Future} that will be completed when the restart 
operation has been done.
        */
       Future<String> restartInstances(String runnable, int instanceId, int... 
moreInstanceIds);
    +
    +  /**
    +   * Set the log levels for requested logger names for Twill applications 
running in a container.
    +   * The log level for a logger name can be {@code null} except for the 
root logger, which will reset the log level for
    --- End diff --
    
    What happen if the caller pass in `null` value for the root logger? Will it 
throw exception? Or will it get ignore?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to