Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r87872004
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/internal/json/TwillRunResourcesCodec.java
 ---
    @@ -66,13 +67,14 @@ public JsonElement serialize(TwillRunResources src, 
Type typeOfSrc, JsonSerializ
       public TwillRunResources deserialize(JsonElement json, Type typeOfT,
                                                JsonDeserializationContext 
context) throws JsonParseException {
         JsonObject jsonObj = json.getAsJsonObject();
    +    Map<String, LogEntry.Level> logLevels =
    +      context.deserialize(jsonObj.get("logLevels"), new 
TypeToken<Map<String, LogEntry.Level>>() { }.getType());
    --- End diff --
    
    Since constants are defined, we should use those constants in 
deserialization as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to