Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94911854
--- Diff:
twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java ---
@@ -33,14 +33,16 @@
/**
* Invoked when new messages is available.
+ * @param startOffset Offset of the first {@link FetchedMessage} in
the iterator of new messages.
--- End diff --
Is it? Or shall it return the offset of the first message being read?
Other, e.g. if `-1L` was specified, and the latest message was read, but not
being consumed by the `onReceived` method. If it returns `-1L`, then that
particular message won't get fetched again if there is a newer message
available. Is that the intention?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
