Github user maochf commented on a diff in the pull request:

    https://github.com/apache/twill/pull/16#discussion_r94912977
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java ---
    @@ -33,14 +33,16 @@
     
         /**
          * Invoked when new messages is available.
    +     * @param startOffset Offset of the first {@link FetchedMessage} in 
the iterator of new messages.
    --- End diff --
    
    Yes, I think one should be able to use `-1L` to fetch an upcoming new 
message, which also aligns with the usage of `-1L` in Kafka's `SimpleConsumer`. 
If the latest message is read, and it's the first message in the iterator, one 
can just specify `startOffset` as the latest message offset if one doesn't want 
to skip it. If the latest message is not the first message in the iterator and 
its previous message was consumed, `onReceived` will still return the latest 
message offset.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to