Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94913560
--- Diff:
twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java ---
@@ -33,14 +33,16 @@
/**
* Invoked when new messages is available.
+ * @param startOffset Offset of the first {@link FetchedMessage} in
the iterator of new messages.
--- End diff --
I understand the behavior, but is it a good API? As you see, it is quite
difficult to explain, hence documenting it correctly. I feel it's much easier
to explain and to use if we say the `startOffset` is the offset of the first
message in the given iterator.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
