Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/16#discussion_r94914909
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java ---
    @@ -33,14 +33,16 @@
     
         /**
          * Invoked when new messages is available.
    +     * @param startOffset Offset of the first {@link FetchedMessage} in 
the iterator of new messages.
    --- End diff --
    
    Not exactly. E.g. let say the offset submitted to Kafka for fetching is 
"0", but the message with offset "0" is already gone, so the actual first 
message fetched is having a larger offset.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to